Properly responds with 404 error when asked for the feed for a missing page
Closes FeedForNonExistentPages
| 108 | def history | def history | 108 |
|---|---|---|---|
| 109 | respond_to do |format| | respond_to do |format| | 109 |
| 110 | format.html | format.html | 110 |
| 111 | format.xml { render(:action => 'page_feed') | format.xml do | 111 |
| 112 | cache_page} | return head(:status => 404) unless @page.revisions.size > 0 | 112 |
render(:action => 'page_feed') | 113 | ||
cache_page | 114 | ||
end | 115 | ||
| 113 | end | end | 116 |
| 114 | end | end | 117 |
| 115 | 118 |
| 549 | assert_no_xml_element "//item/pubDate[text() = 'Tue, 01 Apr 2008 19:23:42 -0300']" | assert_no_xml_element "//item/pubDate[text() = 'Tue, 01 Apr 2008 19:23:42 -0300']" | 549 |
|---|---|---|---|
| 550 | end | end | 550 |
| 551 | 551 | ||
def test_responds_history_for_missing_page_with_http_404_error | 552 | ||
get :history, :page_name => 'MissingPage', :format => 'xml', :locale => 'en' | 553 | ||
assert_response :missing | 554 | ||
end | 555 | ||
| 556 | |||
| 552 | private | private | 557 |
| 553 | 558 | ||
| 554 | def log_as(user_name) | def log_as(user_name) | 559 |