You are here: Home > Latest news from Darcs > Fixes exploding parsing error in RSS feeds

Revision 20080417215546-9043f-0216b8...

Fixes exploding parsing error in RSS feeds

app/helpers/wiki_helper.rb
test/functional/wiki_controller_test.rb

Changes to wiki_helper.rb

55
      xml.dc :creator, h(rev.last_editor.login)
      xml.dc :creator, h(rev.last_editor.login)
55
56
      xml.guid server_url_for(:action => 'show', :page_name => @page.name,
      xml.guid server_url_for(:action => 'show', :page_name => @page.name,
56
57
                              :revision => rev.position)
                              :revision => rev.position)
57
58
    end
    end rescue ''
58
59
  end
  end
59
60
60
61
end
end
61

Changes to wiki_controller_test.rb

537
    assert_tag :div, :attributes => { :class => "message wikierror" }
    assert_tag :div, :attributes => { :class => "message wikierror" }
537
538
  end
  end
538
539
539
 
  def test_feed_ignores_revisions_with_syntax_errors
540
 
    page = pages('page_with_syntax_error')
541
 
542
 
    get :history, :page_name => page.name, :format => 'xml', :locale => 'pt-br'
543
 
    assert_xml_element "//item/pubDate[text() = 'Tue, 01 Apr 2008 18:17:26 -0300']"
544
 
    assert_xml_element "//item/pubDate[text() = 'Tue, 01 Apr 2008 19:23:42 -0300']"
545
 
546
 
    get :history, :page_name => page.name, :format => 'xml', :locale => 'en'
547
 
    assert_xml_element "//item/pubDate[text() = 'Tue, 01 Apr 2008 18:17:26 -0300']"
548
 
    assert_no_xml_element "//item/pubDate[text() = 'Tue, 01 Apr 2008 19:23:42 -0300']"
549
 
  end
550
 
551
540
private
private
552
541
553
542
  def log_as(user_name)
  def log_as(user_name)
554